[Mp4-tech] Is motion vector retrieval wrong in function: voidConceal_Error( ) in the file decoder.c in the encoder?

[Tourapis, Alexis]

Dear Dalei,
Your observation is correct. However, I will warn you that RDOptimization = 3 may contain several other bugs since it has not been maintained by anyone. Note that nothing is done for example for B slices in relationship to list1 or bipred partitions and there are other problems with the code. 
Best regards,
Alexis
________________________________
From: mp4-tech-bounces lists.mpegif.org [mailto:mp4-tech-bounces lists.mpegif.org] On Behalf Of Dalei Wu
Sent: Wednesday, January 30, 2024 10:20 PM
To: mp4-tech lists.mpegif.org
Subject: [Mp4-tech] Is motion vector retrieval wrong in function: voidConceal_Error( ) in the file decoder.c in the encoder?
Dear experts,
I use the simulated decoder in the encoder to simulate decoding with packet loss, I made the following configuration in the file encoder_extended.cfg:
ProfileIDC: 88 (extended)
RDOptimization: 3 (rd-optimized with losses)
PartitionMode: 1 (three partitions) 
LossRateA: 10
LossRateA: 10
LossRateA: 10
When I ran the program, it was stopped by the following MV retrieval in the function of the encoder:
void Conceal_Error(imgpel **inY, int mb_y, int mb_x, imgpel ***refY, byte **s_map)
{
        ...
  switch(s_map[mb_y][mb_x])
  {
     ...
   case 5
     ... 
   mv[i][block_y][block_x]=tmp_mv[mb_y*BLOCK_SIZE+block_y][mb_x*BLOCK_SIZE+block_x+4][i]
     ...
  }
}
why does it need to plus 4 at the block_x direction?
I think it should be
mv[i][block_y][block_x]=tmp_mv[mb_y*BLOCK_SIZE+block_y][mb_x*BLOCK_SIZE+block_x][i]
Thanks,
Dalei
-- 
----------------------------------------------------
Dalei Wu
Computer & Electronics Engineering Dept.
University of Nebraska Lincoln
Omaha, NE, USA 68182-0572
---------------------------------------------------- 
-----------------------------------------
This message (including any attachments) may contain confidential
information intended for a specific individual and purpose.  If you
are not the intended recipient, delete this message.  If you are
not the intended recipient, disclosing, copying, distributing, or
taking any action based on this message is strictly prohibited.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: /pipermail/mp4-tech/attachments/20080130/d05d2c8f/attachment.html